Add Sensor class #265
Merged
Add Sensor class #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roosre
approved these changes
Aug 21, 2023
Contributor
roosre
left a comment
roosre
left a comment
There was a problem hiding this comment.
Thanks for implementing it. See minor comments.
| Inactive sensors are not evaluated. | ||
| entities : | ||
| List of entities which define the sensor's scope. | ||
| """ |
Contributor
There was a problem hiding this comment.
Is it worth to document the result entities?
Member
Author
There was a problem hiding this comment.
I've added a doc attribute to the property helpers, to set the docstring of the properties. Opened #267 as a follow-up to enable documenting the read-write properties (the result entities are read-only) also as both parameter and attribute, without duplication.
janvonrickenbach
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensor attributes which are not set in the API message are exposed as
None.To enable this, the
check_optionalflag is added togrpc_read_only_property.