Skip to content

Conversation

@greschd
Copy link
Member

@greschd greschd commented Jul 2, 2024

Fix installing a custom API branch in the CI pipeline:

  • build the API repository in a separate step, using Python3.10, since
    newer Python versions are not supported by the necessary protobuf version
  • install the API package without dependencies, to avoid accidentally installing
    a transitive dependency which is incompatible with some other dependency

Other changes:

  • Simplify the pipeline logic by using env to process the workflow_dispatch inputs.
    This also allows setting a default value in the CI .yml, for example for a feature branch.

@codecov
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.98%. Comparing base (ad8fb06) to head (34ab2bc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   91.98%   91.98%           
=======================================
  Files          82       82           
  Lines        4252     4252           
=======================================
  Hits         3911     3911           
  Misses        341      341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd force-pushed the maint/use_env_in_ci_action branch from a68e44c to afcf73c Compare July 2, 2024 18:33
@greschd greschd force-pushed the maint/use_env_in_ci_action branch from afcf73c to 1763012 Compare July 2, 2024 18:38
@greschd greschd changed the title CI: Pass workflow_dispatch inputs via env CI: Pass workflow_dispatch inputs via env, fix custom API branch install Jul 2, 2024
@greschd greschd changed the title CI: Pass workflow_dispatch inputs via env, fix custom API branch install CI: Fix custom API branch install Jul 2, 2024
@greschd greschd force-pushed the maint/use_env_in_ci_action branch from f041506 to cc0e645 Compare July 2, 2024 19:07
@greschd greschd force-pushed the maint/use_env_in_ci_action branch from cc0e645 to 34ab2bc Compare July 2, 2024 19:15
@greschd greschd enabled auto-merge (squash) July 2, 2024 19:18
@greschd greschd force-pushed the maint/use_env_in_ci_action branch from 2ca7434 to 34ab2bc Compare July 2, 2024 19:18
@greschd greschd merged commit 93ce405 into main Jul 3, 2024
@greschd greschd deleted the maint/use_env_in_ci_action branch July 3, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants