Skip to content

Drop python 3.9 support #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2024
Merged

Drop python 3.9 support #559

merged 4 commits into from
Sep 19, 2024

Conversation

@greschd
Copy link
Member

@greschd greschd commented Aug 16, 2024 •
edited
Loading

Following the PyAnsys Python version support policy, drop support for 3.9.

Update pre-commit hooks using pre-commit autoupdate.

Add a .git-blame-ignore-revs file to ignore the pyupgrade changes.

@wiz-inc-572fc38784
Copy link

wiz-inc-572fc38784 bot commented Aug 16, 2024 •
edited
Loading

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 1C 2H 7M 2L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 1C 2H 7M 2L 0I
Secrets 0🔑

@greschd greschd changed the base branch from main to feat/ply_geometry_export_to_main August 16, 2024 15:41
@codecov
Copy link

codecov bot commented Aug 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.34884% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (7edaf34) to head (35d0a69).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/acp/core/_server/direct.py 75.00% 1 Missing ⚠️
src/ansys/acp/core/_server/docker_compose.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files          82       82           
  Lines        4296     4297    +1     
=======================================
+ Hits         3998     3999    +1     
  Misses        298      298

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/ply_geometry_export_to_main to main August 20, 2024 15:15
@greschd greschd force-pushed the maint/drop_python_39 branch 2 times, most recently from 5a311ba to 34c0119 Compare August 20, 2024 15:25
@greschd greschd enabled auto-merge (squash) August 20, 2024 15:29
@greschd greschd marked this pull request as draft August 21, 2024 14:15
auto-merge was automatically disabled August 21, 2024 14:15

Pull request was converted to draft

@greschd
Copy link
Member Author

greschd commented Aug 21, 2024

Holding off on this since I want to merge and release #562 first.

@greschd greschd force-pushed the maint/drop_python_39 branch from 7e9ab90 to d099b3b Compare September 17, 2024 09:37
@greschd greschd marked this pull request as ready for review September 17, 2024 09:37
@greschd greschd force-pushed the maint/drop_python_39 branch from e176292 to 35d0a69 Compare September 17, 2024 09:41
@greschd greschd enabled auto-merge September 17, 2024 09:41
@greschd greschd mentioned this pull request Sep 17, 2024
Merged
@greschd greschd merged commit ac9aa18 into main Sep 19, 2024
@greschd greschd deleted the maint/drop_python_39 branch September 19, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roosre roosre roosre approved these changes

@janvonrickenbach janvonrickenbach Awaiting requested review from janvonrickenbach

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greschd @roosre