Skip to content

Conversation

@greschd
Copy link
Member

@greschd greschd commented Aug 26, 2024

The .store() method contains a check that all linked objects are
within the same model. However, this check falsely raised when
given an empty resource path. This is now fixed by filtering out
the empty resource paths in the check.

@greschd greschd enabled auto-merge (squash) August 26, 2024 06:20
@codecov
Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.91%. Comparing base (acee20f) to head (b0678c4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #569   +/-   ##
=======================================
  Coverage   92.91%   92.91%           
=======================================
  Files          82       82           
  Lines        4291     4292    +1     
=======================================
+ Hits         3987     3988    +1     
  Misses        304      304           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd merged commit b4bba30 into main Aug 26, 2024
@greschd greschd deleted the fix/handle_empty_resource_paths_in_clone branch August 26, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants