Skip to content

Conversation

@greschd
Copy link
Member

@greschd greschd commented Sep 16, 2024

Adapt to the change moving the file format definition to enum_types.proto:

Adds an optional argument explicit_value_list to the enum wrapper, which
specifies which of the wrapped values are exposed.

This is used to wrap the enum_types_pb2.FileFormat in different ways, exposing
only the file formats acceptable for a given use.

@codecov
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.06%. Comparing base (9018948) to head (95fb86f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #580      +/-   ##
==========================================
+ Coverage   92.91%   93.06%   +0.14%     
==========================================
  Files          82       82              
  Lines        4293     4296       +3     
==========================================
+ Hits         3989     3998       +9     
+ Misses        304      298       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd force-pushed the maint/update_api_lib branch from 1a5156e to e6a6cc0 Compare September 17, 2024 09:10
@greschd
Copy link
Member Author

greschd commented Sep 17, 2024

Using a pinned API library version for now; otherwise we'd have to use the --pre flag when installing with pip.

Not sure why this worked previously, could be because we now fully specify the version as 0.2.0.dev0 (instead of 0.2.dev0) in the VERSION file of the API library. Or something changed about how poetry packages the wheel or pip consumes it.

In any case, I think we can switch to proper releases for the API library with the next version bump.

@greschd greschd merged commit 7edaf34 into main Sep 17, 2024
@greschd greschd deleted the maint/update_api_lib branch September 17, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants