-
Notifications
You must be signed in to change notification settings - Fork 1
Add ButtJointSequence exposure #606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
- Coverage 93.33% 93.29% -0.04%
==========================================
Files 86 87 +1
Lines 4604 4698 +94
==========================================
+ Hits 4297 4383 +86
- Misses 307 315 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9853384 to
84cd4de
Compare
greschd
commented
Oct 3, 2024
9003bd0 to
62d9a6f
Compare
1ceaa63 to
cfd1142
Compare
Closed
roosre
approved these changes
Oct 23, 2024
cfd1142 to
ee05fe5
Compare
ee05fe5 to
774123c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
ButtJointSequenceclass, and aPrimaryPlyclass for the edge propertiesof the
primary_pliesattribute.Other changes:
allowed_types_getterparameter todefine_polymorphic_linked_object_listwith the same purpose as the existing
allowed_types, except the types are evaluatedonly inside the getter.
This was needed to avoid a circular import with the
ModelingGroup, sincedefine_polymorphic_linked_object_listis called at the module top-level.