Fix tree printer to include all object types #679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greschd
commented
Nov 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
- Coverage 95.04% 94.98% -0.07%
==========================================
Files 109 109
Lines 5716 5685 -31
Branches 324 322 -2
==========================================
- Hits 5433 5400 -33
- Misses 282 284 +2
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
greschd
force-pushed
the
fix/tree_printer
branch
2 times, most recently
from
959ecd2 to
31c84a9
Compare
Change the implementation of 'get_model_tree' to use the '_GRPC_PROPERTIES' class attribute, and thus include all newly-added object types in the representation. The style of the tree has changed in some ways: - The root node now shows the model name, instead of always 'Model' - Objects (name or id) are distinguished from collections by wrapping the string in single quotes - The additional nesting level for 'Materials', 'Selection Rules', and other 'logical' groupings which are not part of the PyACP hierarchy has been removed [1] [1] This change might be debatable since the ACP GUI does show this nesting level. Since the PyACP hierarchy does not include them, it would be complicated to add them in a generic way, however. To discuss: should the collection names be capitalized (as done currently), or not (matching the PyACP attribute names)? The new tree structure can be seen in the updated test cases. Partially addresses #348, interactive tree support in Jupyter notebooks is still missing.
greschd
force-pushed
the
fix/tree_printer
branch
from
31c84a9 to
a5dd9dc
Compare
roosre
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the implementation of 'get_model_tree' to use the '_GRPC_PROPERTIES' class attribute, and thus include all newly-added object types in the representation.
The style of the tree has changed in some ways:
The new tree structure can be seen in the updated test cases, or in
print_model.rst.Partially addresses #348, interactive tree support in Jupyter notebooks is still missing.