Skip to content

Conversation

@roosre
Copy link
Contributor

@roosre roosre commented Nov 28, 2024

Additional changes:

  • Remove example from the titles
  • add solid_mesh property to ImportedAnalysisPly and ImportedSolidModel
  • refine some plots (hide edges, set camera position)

…model and imported solid model examples.

Add solid_mesh property to the imported solid model and imported_analysis_ply.
@codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (d440904) to head (f54868d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   94.98%   94.99%           
=======================================
  Files         109      109           
  Lines        5685     5693    +8     
  Branches      322      322           
=======================================
+ Hits         5400     5408    +8     
  Misses        284      284           
  Partials        1        1           
Flag Coverage Δ
direct-launch 91.58% <100.00%> (+0.01%) ⬆️
minimum-deps 93.19% <100.00%> (+<0.01%) ⬆️
python-3.10 94.25% <100.00%> (+<0.01%) ⬆️
python-3.11 94.18% <100.00%> (+<0.01%) ⬆️
python-3.12 94.37% <100.00%> (+<0.01%) ⬆️
server-2024R2 90.81% <100.00%> (+0.01%) ⬆️
server-2025R1 94.18% <100.00%> (+<0.01%) ⬆️
server-2025R2 94.18% <100.00%> (+<0.01%) ⬆️
server-latest 94.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roosre roosre changed the title Add example to demonstrate the hdf5 composite cae interface Add example for Imported Plies and the hdf5 composite cae interface Nov 28, 2024
@roosre roosre mentioned this pull request Nov 27, 2024
13 tasks
@roosre roosre marked this pull request as ready for review November 28, 2024 10:39
Copy link
Member

@greschd greschd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another cool set of examples! I just added some minor comments.

roosre and others added 3 commits November 28, 2024 13:43
Co-authored-by: Dominik Gresch <greschd@users.noreply.github.com>
Co-authored-by: Dominik Gresch <greschd@users.noreply.github.com>
@roosre roosre enabled auto-merge (squash) November 28, 2024 12:47
@roosre roosre merged commit 799a674 into main Nov 28, 2024
33 checks passed
@roosre roosre deleted the docs/imported_plies_and_hdf5_composite_cae branch November 28, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants