Skip to content

Conversation

@greschd
Copy link
Member

@greschd greschd commented Nov 28, 2024

Comment out the price attribute on the ModelElementalData, as a workaround to #717.

Add a mass plot to the imported solid model example.

Closes #717.
Follow-up tasks tracked by #720.

@greschd greschd force-pushed the fix/remove_crashing_elemental_data_price branch from 478eccf to 8e93600 Compare November 28, 2024 19:29
@codecov
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (3ae9d16) to head (73cef38).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #721      +/-   ##
==========================================
- Coverage   94.99%   94.99%   -0.01%     
==========================================
  Files         109      109              
  Lines        5695     5694       -1     
  Branches      322      322              
==========================================
- Hits         5410     5409       -1     
  Misses        284      284              
  Partials        1        1              
Flag Coverage Δ
direct-launch 91.58% <ø> (-0.01%) ⬇️
minimum-deps 93.19% <ø> (-0.01%) ⬇️
python-3.10 94.25% <ø> (-0.01%) ⬇️
python-3.11 94.18% <ø> (-0.01%) ⬇️
python-3.12 94.38% <ø> (-0.01%) ⬇️
server-2024R2 90.81% <ø> (-0.01%) ⬇️
server-2025R1 94.18% <ø> (-0.01%) ⬇️
server-2025R2 94.18% <ø> (-0.01%) ⬇️
server-latest 94.80% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment out the `price` attribute on the `ModelElementalData`, as
a workaround to #717.

Add a mass plot to the imported solid model example.

Closes #717.
Follow-up tasks tracked by #720.
@greschd greschd force-pushed the fix/remove_crashing_elemental_data_price branch from f140e26 to 73cef38 Compare November 29, 2024 12:21
@greschd greschd enabled auto-merge (squash) November 29, 2024 12:21
@greschd greschd merged commit ec6d153 into main Nov 29, 2024
32 checks passed
@greschd greschd deleted the fix/remove_crashing_elemental_data_price branch November 29, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on plotting elemental data on an imported solid model

3 participants