Skip to content

Conversation

@greschd
Copy link
Member

@greschd greschd commented Dec 3, 2024

Make the example thumbnails in the documentation bigger:

  • Create the thumbnails in 4:3 aspect ratio, which matches the aspect ratio used when creating images in the examples. This avoids empty space on the top / bottom of the thumbnail.
  • Increase the max-width and max-height of the thumbnails to 100% by adding a custom CSS file.

@greschd
Copy link
Member Author

greschd commented Dec 3, 2024

Old:
image

New:
image

@codecov
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (dfa81e7) to head (34fdffb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files         109      109           
  Lines        5695     5695           
  Branches      322      322           
=======================================
  Hits         5410     5410           
  Misses        284      284           
  Partials        1        1           
Flag Coverage Δ
direct-launch 91.58% <ø> (ø)
minimum-deps 93.19% <ø> (ø)
python-3.10 94.25% <ø> (ø)
python-3.11 94.18% <ø> (ø)
python-3.12 94.38% <ø> (ø)
server-2024R2 90.81% <ø> (ø)
server-2025R1 94.18% <ø> (ø)
server-2025R2 94.18% <ø> (ø)
server-latest 94.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd marked this pull request as draft December 3, 2024 13:57
Make the example thumbnails in the documentation bigger:
- Create the thumbnails in 4:3 aspect ratio, which matches the
  aspect ratio used when creating images in the examples. This
  avoids empty space on the top / bottom of the thumbnail.
- Increase the `max-width` and `max-height` of the thumbnails
  to 100% by adding a custom CSS file.
@greschd greschd force-pushed the docs/thumbnail_size branch from b13e574 to c9be5ec Compare December 3, 2024 14:09
@greschd greschd marked this pull request as ready for review December 3, 2024 14:10
@greschd greschd added documentation Improvements or additions to documentation enhancement Improvement to an existing feature labels Dec 3, 2024
@greschd greschd requested a review from SRaimondi December 3, 2024 14:30
@roosre
Copy link
Contributor

roosre commented Dec 3, 2024

Cool. Thanks for having a look.

@greschd greschd enabled auto-merge (squash) December 3, 2024 14:46
@greschd greschd merged commit 8be6a44 into main Dec 3, 2024
32 checks passed
@greschd greschd deleted the docs/thumbnail_size branch December 3, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement Improvement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants