Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@AlejandroFernandezLuces AlejandroFernandezLuces linked an issue Oct 21, 2025 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added testing Anything related to tests bug Something isn't working labels Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.35%. Comparing base (73cc9d8) to head (b5b5d71).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2337   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         168      168           
  Lines       11072    11072           
=======================================
  Hits        10558    10558           
  Misses        514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review October 21, 2025 09:54
@AlejandroFernandezLuces AlejandroFernandezLuces requested a review from a team as a code owner October 21, 2025 09:54
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and the testing @AlejandroFernandezLuces .

@AlejandroFernandezLuces AlejandroFernandezLuces merged commit 5c82731 into main Oct 21, 2025
49 checks passed
@AlejandroFernandezLuces AlejandroFernandezLuces deleted the fix/decorator-order branch October 21, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in ...launch_modeler_with_core_service

3 participants