Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

  • reviewing functions that accept Reals to accept Distance and Quantity

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Oct 21, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner October 21, 2025 17:11
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.35%. Comparing base (5c82731) to head (cda6209).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/tools/prepare_tools.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2340   +/-   ##
=======================================
  Coverage   95.35%   95.35%           
=======================================
  Files         168      168           
  Lines       11072    11094   +22     
=======================================
+ Hits        10558    10579   +21     
- Misses        514      515    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@jonahrb jonahrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobrkerstetter jacobrkerstetter merged commit 1c856df into main Oct 21, 2025
50 checks passed
@jacobrkerstetter jacobrkerstetter deleted the chore/add_unit_support branch October 21, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants