Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

allow for circular patterns to be created about an arbitrary axis defined by a Line

Issue linked

closes #1951

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Nov 11, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner November 11, 2025 16:44
@github-actions github-actions bot added the bug Something isn't working label Nov 11, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.20%. Comparing base (1ef2779) to head (513ab90).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../ansys/geometry/core/designer/geometry_commands.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
- Coverage   95.20%   95.20%   -0.01%     
==========================================
  Files         168      168              
  Lines       11103    11108       +5     
==========================================
+ Hits        10571    10575       +4     
- Misses        532      533       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label Nov 11, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments - once resolved I'll approve =)

jacobrkerstetter and others added 2 commits November 12, 2025 08:02
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, let's get this one in!

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) November 12, 2025 13:20
@jacobrkerstetter jacobrkerstetter merged commit 1e20fa2 into main Nov 12, 2025
51 checks passed
@jacobrkerstetter jacobrkerstetter deleted the fix/add_axis_for_circular_pattern branch November 12, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create_circular_pattern should be able to take as input an axis to revolve the pattern around

4 participants