-
Notifications
You must be signed in to change notification settings - Fork 22
fix: add axis for circular pattern #2367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… fix/add_axis_for_circular_pattern
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
==========================================
- Coverage 95.20% 95.20% -0.01%
==========================================
Files 168 168
Lines 11103 11108 +5
==========================================
+ Hits 10571 10575 +4
- Misses 532 533 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small comments - once resolved I'll approve =)
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, let's get this one in!
Description
allow for circular patterns to be created about an arbitrary axis defined by a Line
Issue linked
closes #1951
Checklist
feat: extrude circle to cylinder)