feat: expose enclosure methods #2383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR exposes 3 separate APIs for the creation of Box, Cylinder and Sphere enclosure. Enclosure options are common to the 3 cases. Specific argument are given to each method and grpc request
smereu
requested review from
RobPasMue,
b-matteo,
jacobrkerstetter and
umutsoysalansys
Contributor
Author
|
@RobPasMue @jacobrkerstetter I put the EnclosureOption class in the Preparetools file, but I can move it to a separate one if we think it is a better pattern |
Contributor
Author
|
@RobPasMue I think it is ready for approval now, minus the fact that there are again two spurious file that don't show up for me in github when I do my commit. Do I need to remove them? |
jacobrkerstetter
requested changes
Nov 19, 2025
Contributor
jacobrkerstetter
left a comment
jacobrkerstetter
left a comment
There was a problem hiding this comment.
I had one more comment about the EnclosureOptions. Other than that looks great! 😄
Member
No need @smereu - I cleaned up the wrong file for you.. we should really check why you have that file on your side... it's not the first time I see it |
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…sys/pyansys-geometry into feat/expose_enclosure_methods
model used was too new for 24.2 and before 25.1 & 25.2 work fine
…sys/pyansys-geometry into feat/expose_enclosure_methods
RobPasMue
reviewed
Nov 20, 2025
RobPasMue
reviewed
Nov 20, 2025
jacobrkerstetter
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the APIs for enclosure creation. 3 separate APIs are used for box, cylinder and sphere enclosure. Enclosure_options are common to the 3 methods. Other specific arguments are given for each method and corresponding grpc request.
Issue linked
See https://tfs.ansys.com:8443/tfs/ANSYS_Development/Portfolio/_workitems/edit/1369379 request for a zero cushion cylinder enclosure
Checklist
feat: extrude circle to cylinder)