Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

  • added pytest fixture to specify protos version
  • edited yml file to have a job for windows and linux to test
  • these will not be required until all v1 stubs are implemented

Issue linked

Testing related to #2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

added pytest fixture
@jacobrkerstetter jacobrkerstetter self-assigned this Nov 19, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner November 19, 2025 20:20
@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (a2bdd22) to head (7a1cba4).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2389      +/-   ##
==========================================
+ Coverage   95.11%   95.21%   +0.09%     
==========================================
  Files         168      168              
  Lines       11290    11290              
==========================================
+ Hits        10739    10750      +11     
+ Misses        551      540      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm couple of things..

  • Do we really need the stable/unstable logic for the v1 tests? I would simply run against the latest stable
  • It might be easier for you to look at minimum requirements stages or the no graphics stages, rather than the main testing stages -- the v1 testing should be simpler I believe
  • I really like what you did with the proto_version fixture. That way it also forces v0 input to work properly as well.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although it's going to be very annoying to see all the workflows fail constantly..

What if we create a separate workflow file, like the one we have for backwards compatibility. And only have it run on Pull Requests or on demand (workflow_dispatch) for now?

RobPasMue
RobPasMue previously approved these changes Nov 21, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good - let's merge this!

@RobPasMue RobPasMue merged commit 9a24218 into main Nov 21, 2025
40 of 41 checks passed
@RobPasMue RobPasMue deleted the ci/add_v1_testing branch November 21, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants