Repository navigation
ci: adding testing for v1 protos - #2389
Merged
Merged
Conversation
added pytest fixture
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2389 +/- ##
==========================================
+ Coverage 95.11% 95.21% +0.09%
==========================================
Files 168 168
Lines 11290 11290
==========================================
+ Hits 10739 10750 +11
+ Misses 551 540 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
reviewed
Nov 20, 2025
Member
There was a problem hiding this comment.
Hmm couple of things..
- Do we really need the stable/unstable logic for the v1 tests? I would simply run against the latest stable
- It might be easier for you to look at minimum requirements stages or the no graphics stages, rather than the main testing stages -- the v1 testing should be simpler I believe
- I really like what you did with the
proto_versionfixture. That way it also forces v0 input to work properly as well.
testing against python 3.10 and 3.13 only
RobPasMue
reviewed
Nov 20, 2025
RobPasMue
left a comment
Member
There was a problem hiding this comment.
LGTM - although it's going to be very annoying to see all the workflows fail constantly..
What if we create a separate workflow file, like the one we have for backwards compatibility. And only have it run on Pull Requests or on demand (workflow_dispatch) for now?
RobPasMue
previously approved these changes
Nov 21, 2025
RobPasMue
left a comment
Member
There was a problem hiding this comment.
All good - let's merge this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue linked
Testing related to #2388
Checklist
feat: extrude circle to cylinder)