Skip to content

Conversation

@jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Nov 20, 2025

Description

Add a specialized _combine_subtract() that has the ability to transfer the named selections of the tool body onto the target body after the subtraction.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb self-assigned this Nov 20, 2025
@jonahrb jonahrb requested a review from a team as a code owner November 20, 2025 16:22
@github-actions github-actions bot added the enhancement New features or code improvements label Nov 20, 2025
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.07%. Comparing base (61bffdd) to head (b192ab0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/body.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
+ Coverage   94.95%   95.07%   +0.12%     
==========================================
  Files         169      169              
  Lines       11327    11341      +14     
==========================================
+ Hits        10755    10783      +28     
+ Misses        572      558      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the testing Anything related to tests label Nov 20, 2025
@jonahrb jonahrb enabled auto-merge (squash) November 20, 2025 23:17
RobPasMue
RobPasMue previously approved these changes Nov 21, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM affter the small commits I performed for cleanup. Thanks @jonahrb !

@RobPasMue
Copy link
Member

@jonahrb - looks like the service doesn't have the features implemented properly? Something's wrong at least - not sure what it is.

RobPasMue
RobPasMue previously approved these changes Nov 21, 2025
RobPasMue
RobPasMue previously approved these changes Nov 21, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Nov 21, 2025
@RobPasMue RobPasMue disabled auto-merge November 21, 2025 18:18
@RobPasMue RobPasMue merged commit 0360761 into main Nov 21, 2025
53 of 55 checks passed
@RobPasMue RobPasMue deleted the feat/boolean-transfer-ns branch November 21, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants