-
Notifications
You must be signed in to change notification settings - Fork 22
feat: transfer named selections for special boolean subtract #2392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jacobrkerstetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2392 +/- ##
==========================================
+ Coverage 94.95% 95.07% +0.12%
==========================================
Files 169 169
Lines 11327 11341 +14
==========================================
+ Hits 10755 10783 +28
+ Misses 572 558 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM affter the small commits I performed for cleanup. Thanks @jonahrb !
|
@jonahrb - looks like the service doesn't have the features implemented properly? Something's wrong at least - not sure what it is. |
Description
Add a specialized
_combine_subtract()that has the ability to transfer the named selections of the tool body onto the target body after the subtraction.Issue linked
Checklist
feat: extrude circle to cylinder)