Skip to content

feat: sweepable body detection #2394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 26, 2025
Merged

feat: sweepable body detection #2394

merged 17 commits into from
Nov 26, 2025

Conversation

@jacobrkerstetter
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter commented Nov 20, 2025

Description

  • implemented detect sweepable bodies api
  • includes quick check if body/list of bodies is sweepable
  • includes flag to return source and target faces

Issue linked

Related to TFS Task 1365545

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter
wip - needs testing
2148d77
@jacobrkerstetter
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
52a11ec 
… feat/sweepable_body_detection
@jacobrkerstetter
wip - cs failure
303d27c
@jacobrkerstetter
Merge branch 'main' of https://github.com/ansys/pyansys-geometry into…
9afb244 
… feat/sweepable_body_detection

# Conflicts:
#	src/ansys/geometry/core/_grpc/_services/base/prepare_tools.py
#	src/ansys/geometry/core/_grpc/_services/v0/prepare_tools.py
#	src/ansys/geometry/core/_grpc/_services/v1/prepare_tools.py
#	src/ansys/geometry/core/tools/prepare_tools.py
#	tests/integration/test_prepare_tools.py
@jacobrkerstetter
finalize testing and accepting multiple bodies to detect sweepability
44ccdee
@jacobrkerstetter jacobrkerstetter self-assigned this Nov 20, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner November 20, 2025 20:03
@jacobrkerstetter jacobrkerstetter marked this pull request as draft November 20, 2025 20:03
@github-actions github-actions bot added the enhancement New features or code improvements label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.90%. Comparing base (3ab596f) to head (b2fa009).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2394      +/-   ##
==========================================
+ Coverage   91.85%   91.90%   +0.04%     
==========================================
  Files         169      169              
  Lines       11841    11862      +21     
==========================================
+ Hits        10877    10902      +25     
+ Misses        964      960       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter marked this pull request as ready for review November 24, 2025 18:29
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 24, 2025
RobPasMue
RobPasMue previously approved these changes Nov 25, 2025
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty awesome!

@jacobrkerstetter jacobrkerstetter enabled auto-merge (squash) November 25, 2025 17:03
@github-actions github-actions bot removed the maintenance Package and maintenance related label Nov 25, 2025
@github-actions github-actions bot added the testing Anything related to tests label Nov 26, 2025
@jacobrkerstetter jacobrkerstetter merged commit 47d5cf6 into main Nov 26, 2025
51 checks passed
@jacobrkerstetter jacobrkerstetter deleted the feat/sweepable_body_detection branch November 26, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@jacobrkerstetter jacobrkerstetter

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacobrkerstetter @RobPasMue @pyansys-ci-bot