Skip to content

Conversation

@smereu
Copy link
Contributor

@smereu smereu commented Nov 20, 2025

Description

In creating the v1 version of the original dbuapplication file the following changes were made

  • File dbuapplication has been renamed to commands_script (it only invokes runscriptfile stub)
  • Service GRPCDbuApplicationService has been renamed GRPCCommandsScriptService
  • internal method has been renamed from run_script to run_script_file

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

pyansys-ci-bot and others added 20 commits February 17, 2025 14:31
In creating the v1 version of  the original dbuapplication file the following changes were made
- File dbuapplication has been renamed to commands_script (it only invokes runscriptfile stub)
- Service GRPCDbuApplicationService has been renamed GRPCCommandsScriptService
- internal method has been renamed from run_script to run_script_file
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 20, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 20, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.21%. Comparing base (9a24218) to head (9d7c015).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2395      +/-   ##
==========================================
+ Coverage   95.18%   95.21%   +0.03%     
==========================================
  Files         168      168              
  Lines       11290    11290              
==========================================
+ Hits        10746    10750       +4     
+ Misses        544      540       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue enabled auto-merge (squash) November 21, 2025 07:46
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 21, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 21, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 21, 2025
@RobPasMue RobPasMue disabled auto-merge November 21, 2025 08:54
@RobPasMue RobPasMue merged commit 454f13e into main Nov 21, 2025
50 of 51 checks passed
@RobPasMue RobPasMue deleted the ci/dbu_application_to_commands_script_v1 branch November 21, 2025 08:55
@RobPasMue RobPasMue mentioned this pull request Nov 21, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants