Skip to content

Conversation

@umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Nov 21, 2025

Description

unsupported stub with updated naming in v1

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 21, 2025
@umutsoysalansys umutsoysalansys marked this pull request as ready for review November 21, 2025 17:05
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner November 21, 2025 17:05
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about the imports but everything else looks good!

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.98%. Comparing base (61bffdd) to head (d8e911c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2397      +/-   ##
==========================================
+ Coverage   94.95%   94.98%   +0.03%     
==========================================
  Files         169      169              
  Lines       11327    11329       +2     
==========================================
+ Hits        10755    10761       +6     
+ Misses        572      568       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobrkerstetter jacobrkerstetter mentioned this pull request Nov 21, 2025
23 tasks
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue merged commit aedb0ee into main Nov 21, 2025
50 of 51 checks passed
@RobPasMue RobPasMue deleted the feat/v1-unsupported-stub branch November 21, 2025 18:19
@jacobrkerstetter jacobrkerstetter changed the title feat: v1 unsupported stub chore: v1 implementation of unsupported stub Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants