Skip to content

Conversation

@umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Nov 21, 2025

Description

Bodies implementation for V1.

Notes:
Many tests are failing with same reason hopefully will be resolved with further updates of versioning.

FAILED tests/integration/test_design.py::test_set_body_name - TypeError: Message must be initialized with a dict: ansys.api.discovery.v1.Point

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 21, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 21, 2025
@github-actions github-actions bot removed the maintenance Package and maintenance related label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.13%. Comparing base (456480d) to head (6d73074).

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v1/conversions.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2400      +/-   ##
==========================================
- Coverage   92.16%   92.13%   -0.04%     
==========================================
  Files         169      169              
  Lines       11804    11809       +5     
==========================================
+ Hits        10879    10880       +1     
- Misses        925      929       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue RobPasMue mentioned this pull request Nov 21, 2025
23 tasks
@umutsoysalansys umutsoysalansys changed the title feat: bodiesv1 stub chore: bodiesv1 stub Nov 21, 2025
@jacobrkerstetter jacobrkerstetter changed the title chore: bodiesv1 stub chore: v1 implementation of bodies stub Nov 24, 2025
@umutsoysalansys umutsoysalansys marked this pull request as ready for review November 25, 2025 16:13
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner November 25, 2025 16:13
@umutsoysalansys
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants