Skip to content

Conversation

@umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Nov 21, 2025

Description

V1 implementation for Components.

Issue linked

#2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the enhancement New features or code improvements label Nov 21, 2025
@umutsoysalansys umutsoysalansys self-assigned this Nov 21, 2025
@umutsoysalansys umutsoysalansys mentioned this pull request Nov 21, 2025
23 tasks
@umutsoysalansys umutsoysalansys changed the title feat: update components stub for v1 chore: update components stub for v1 Nov 21, 2025
@jacobrkerstetter jacobrkerstetter changed the title chore: update components stub for v1 chore: v1 implementation of components stub Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 7.89474% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.69%. Comparing base (295caaa) to head (f7d2c54).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...sys/geometry/core/_grpc/_services/v1/components.py 5.40% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2401      +/-   ##
==========================================
- Coverage   92.89%   92.69%   -0.21%     
==========================================
  Files         169      169              
  Lines       11675    11704      +29     
==========================================
+ Hits        10846    10849       +3     
- Misses        829      855      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@umutsoysalansys umutsoysalansys marked this pull request as ready for review November 24, 2025 17:44
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner November 24, 2025 17:44
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a comment or two - Also a note (mostly for myself) to go back and fix the measurement conversions to go to the new Quantity proto message

Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment, other than that looks good!

@umutsoysalansys umutsoysalansys enabled auto-merge (squash) November 25, 2025 12:40
@umutsoysalansys umutsoysalansys merged commit b9faa09 into main Nov 25, 2025
54 of 55 checks passed
@umutsoysalansys umutsoysalansys deleted the feat/components-stub-v1 branch November 25, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants