-
Notifications
You must be signed in to change notification settings - Fork 22
chore: v1 implementation of components stub #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2401 +/- ##
==========================================
- Coverage 92.89% 92.69% -0.21%
==========================================
Files 169 169
Lines 11675 11704 +29
==========================================
+ Hits 10846 10849 +3
- Misses 829 855 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobrkerstetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a comment or two - Also a note (mostly for myself) to go back and fix the measurement conversions to go to the new Quantity proto message
jacobrkerstetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one comment, other than that looks good!
Description
V1 implementation for Components.
Issue linked
#2388
Checklist
feat: extrude circle to cylinder)