-
Notifications
You must be signed in to change notification settings - Fork 22
chore: v1 implementation of coordinate system stub #2402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2402 +/- ##
=======================================
Coverage 92.97% 92.97%
=======================================
Files 169 169
Lines 11656 11657 +1
=======================================
+ Hits 10837 10838 +1
Misses 819 819 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobrkerstetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the one comment!
src/ansys/geometry/core/_grpc/_services/v1/coordinate_systems.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jacob Kerstetter <83893427+jacobrkerstetter@users.noreply.github.com>
jacobrkerstetter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Umut! Looks good!
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @umutsoysalansys !
Description
Coordinate system implementation for the V1. Note that major difference in v0 and v1 is that now create request can take multiple coordinate system data as a form of array (see repeated type in the proto file). As a reesult old request is converted to an array of 1 item and passed as so. Once we have a clear way of making multiple coordinate creation in python side, we can update this further.
Issue linked
Checklist
feat: extrude circle to cylinder)