Skip to content

Conversation

@umutsoysalansys
Copy link
Contributor

@umutsoysalansys umutsoysalansys commented Nov 21, 2025

Description

Coordinate system implementation for the V1. Note that major difference in v0 and v1 is that now create request can take multiple coordinate system data as a form of array (see repeated type in the proto file). As a reesult old request is converted to an array of 1 item and passed as so. Once we have a clear way of making multiple coordinate creation in python side, we can update this further.

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@umutsoysalansys umutsoysalansys self-assigned this Nov 21, 2025
@github-actions github-actions bot added the enhancement New features or code improvements label Nov 21, 2025
@umutsoysalansys umutsoysalansys mentioned this pull request Nov 21, 2025
23 tasks
@umutsoysalansys umutsoysalansys changed the title feat: coordinate_system implementation chore: coordinate_system implementation Nov 21, 2025
@jacobrkerstetter jacobrkerstetter changed the title chore: coordinate_system implementation chore: v1 implementation of coordinate system stub Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.97%. Comparing base (3a535c7) to head (61ae123).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2402   +/-   ##
=======================================
  Coverage   92.97%   92.97%           
=======================================
  Files         169      169           
  Lines       11656    11657    +1     
=======================================
+ Hits        10837    10838    +1     
  Misses        819      819           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@umutsoysalansys umutsoysalansys marked this pull request as ready for review November 24, 2025 16:18
@umutsoysalansys umutsoysalansys requested a review from a team as a code owner November 24, 2025 16:18
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the one comment!

Co-authored-by: Jacob Kerstetter <83893427+jacobrkerstetter@users.noreply.github.com>
Copy link
Contributor

@jacobrkerstetter jacobrkerstetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Umut! Looks good!

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @umutsoysalansys !

@umutsoysalansys umutsoysalansys enabled auto-merge (squash) November 24, 2025 16:47
@umutsoysalansys umutsoysalansys merged commit bfdb0d9 into main Nov 24, 2025
51 of 55 checks passed
@umutsoysalansys umutsoysalansys deleted the feat/-coordinate-system-v1 branch November 24, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants