Skip to content

Conversation

@RobPasMue
Copy link
Member

Description

Including the usage of secure channels upon request

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue requested a review from a team as a code owner November 25, 2025 08:28
@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to tests enhancement New features or code improvements labels Nov 25, 2025
@RobPasMue RobPasMue self-assigned this Nov 25, 2025
jorgepiloto
jorgepiloto previously approved these changes Nov 25, 2025
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature!

SMoraisAnsys
SMoraisAnsys previously approved these changes Nov 25, 2025
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 25.80645% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.19%. Comparing base (b9faa09) to head (c478a38).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 5.26% 54 Missing ⚠️
.../ansys/geometry/core/connection/docker_instance.py 18.75% 13 Missing ⚠️
src/ansys/geometry/core/connection/client.py 87.50% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2411      +/-   ##
==========================================
- Coverage   92.69%   92.19%   -0.51%     
==========================================
  Files         169      169              
  Lines       11704    11787      +83     
==========================================
+ Hits        10849    10867      +18     
- Misses        855      920      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 25, 2025
MaxJPRey
MaxJPRey previously approved these changes Nov 25, 2025
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RobPasMue RobPasMue merged commit 2b98dc6 into main Nov 25, 2025
50 of 51 checks passed
@RobPasMue RobPasMue deleted the feat/secure-grpc branch November 25, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants