Skip to content

Conversation

@jacobrkerstetter
Copy link
Contributor

Description

As title says

Issue linked

Related to #2388

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jacobrkerstetter jacobrkerstetter self-assigned this Nov 25, 2025
@jacobrkerstetter jacobrkerstetter requested a review from a team as a code owner November 25, 2025 16:35
@jacobrkerstetter jacobrkerstetter mentioned this pull request Nov 25, 2025
23 tasks
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 7.89474% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.95%. Comparing base (456480d) to head (5bfe686).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v1/model_tools.py 2.77% 35 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2413      +/-   ##
==========================================
- Coverage   92.16%   91.95%   -0.21%     
==========================================
  Files         169      169              
  Lines       11804    11834      +30     
==========================================
+ Hits        10879    10882       +3     
- Misses        925      952      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobPasMue RobPasMue merged commit 5bde7de into main Nov 26, 2025
57 checks passed
@RobPasMue RobPasMue deleted the chore/v1_measurement_model_tools branch November 26, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants