chore: v1 implementation of patterns stub #2416
Open
+190
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chore/v1_faces_edges_impl # Conflicts: # src/ansys/geometry/core/_grpc/_services/v1/conversions.py
fixing some conversions and small bugs
…pyansys-geometry into chore/v1_faces_edges_impl
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2416 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 169 169
Lines 11804 11806 +2
=======================================
+ Hits 10879 10881 +2
Misses 925 925 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RobPasMue
requested changes
Nov 26, 2025
Member
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Let's move these defaults upwards.. please revisit v0 to make sure that it is aligned as well
Comment on lines
+73
to
+77
| pitch_y=( | ||
| from_length_to_grpc_quantity(kwargs["pitch_y"]) | ||
| if kwargs["pitch_y"] | ||
| else from_length_to_grpc_quantity(Distance(0)) | ||
| ), |
Member
There was a problem hiding this comment.
Shouldn't this come from the call itself? I would rather avoid any logic inside the _grpc layer
Comment on lines
+138
to
+143
| # Create linear pitch if not None | ||
| linear_pitch = ( | ||
| from_length_to_grpc_quantity(kwargs["linear_pitch"]) | ||
| if kwargs["linear_pitch"] | ||
| else from_length_to_grpc_quantity(Distance(0.0)) | ||
| ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As title says
Issue linked
Related to #2388
Checklist
feat: extrude circle to cylinder)