Skip to content

Conversation

@smereu
Copy link
Contributor

@smereu smereu commented Nov 25, 2025

Description

Adjust the request and response to account for the v1 changes. Also to the services information to process the changes
To do: consolidate the response in a common function to avoid cut and paste

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

pyansys-ci-bot and others added 23 commits February 17, 2025 14:31
First draft of prepare_tools to v1 implementation
@smereu smereu self-assigned this Nov 25, 2025
@smereu smereu requested a review from a team as a code owner November 25, 2025 23:18
@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 25, 2025
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 25, 2025
clean-up of response to use a common method. Restore compatibility with previous version
@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 26, 2025
@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.87%. Comparing base (b9faa09) to head (336d1b9).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/tools/prepare_tools.py 0.00% 17 Missing ⚠️
...ys/geometry/core/_grpc/_services/v1/conversions.py 20.00% 4 Missing ⚠️

❌ Your project check has failed because the head coverage (79.87%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (b9faa09) and HEAD (336d1b9). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (b9faa09) HEAD (336d1b9)
6 2
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2417       +/-   ##
===========================================
- Coverage   92.69%   79.87%   -12.82%     
===========================================
  Files         169      157       -12     
  Lines       11704    11623       -81     
===========================================
- Hits        10849     9284     -1565     
- Misses        855     2339     +1484     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot added maintenance Package and maintenance related and removed maintenance Package and maintenance related labels Nov 26, 2025
@RobPasMue RobPasMue mentioned this pull request Nov 26, 2025
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants