-
Notifications
You must be signed in to change notification settings - Fork 22
chore: prepare tools to v1 #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
First draft of prepare_tools to v1 implementation
clean-up of response to use a common method. Restore compatibility with previous version
…nsys-geometry into ci/prepare_tools_to_v1
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (79.87%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #2417 +/- ##
===========================================
- Coverage 92.69% 79.87% -12.82%
===========================================
Files 169 157 -12
Lines 11704 11623 -81
===========================================
- Hits 10849 9284 -1565
- Misses 855 2339 +1484 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Adjust the request and response to account for the v1 changes. Also to the services information to process the changes
To do: consolidate the response in a common function to avoid cut and paste
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist
feat: extrude circle to cylinder)