-
Couldn't load subscription status.
- Fork 0
feat: improve stft plot computation time #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #287 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 81 81
Lines 4977 4976 -1
=========================================
- Hits 4977 4976 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anssmolla
reviewed
Jun 3, 2025
anssmolla
previously approved these changes
Jun 3, 2025
anssmolla
previously approved these changes
Jun 3, 2025
anscquesson
previously approved these changes
Jun 3, 2025
anscquesson
approved these changes
Jun 3, 2025
anssmolla
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plotting STFTs would be quite time-consuming, for 2 reasons:
To remedy these:
More generally, these changes improve computation times in any situation where the STFT data is being retrieved as a numpy array (meaning it also improves computation times for some other example scripts that this PR did not change)
Computation times during CI/CD before these changes:

Computation times during CI/CD after these changes:

(also improved some minor code readability issues)