-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Use in-process server by default when using local server #289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #289 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 81 81
Lines 4976 4998 +22
=========================================
+ Hits 4976 4998 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
anssmolla
reviewed
Jun 10, 2025
src/ansys/sound/core/server_helpers/_connect_to_or_start_server.py
Outdated
Show resolved
Hide resolved
anssmolla
previously approved these changes
Jun 12, 2025
anscquesson
previously approved these changes
Jun 13, 2025
d713bf8
anshlachamb
approved these changes
Jun 13, 2025
anscquesson
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New features or code improvements
examples
Examples and tutorials
testing
Tests and testing related
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a local server, an
InProcessserver is now used by default (as opposed to agRPCserver previously).An additional argument was added to still allow using a local
gRPCserver if needed.Also, example 001 was modified as the local server test did not work as expected