Skip to content

feat: type hint and docstring length #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Oct 18, 2024
Merged

feat: type hint and docstring length #340

merged 32 commits into from
Oct 18, 2024

Conversation

@clatapie
Copy link
Collaborator

@clatapie clatapie commented Oct 16, 2024 •
edited
Loading

This PR:

  • add type hint to each generated function
  • fixes most of the issues related to the issues of the docstrings

Some docstrings are still too long. It is most of the time due the fact the line is in a list.

@clatapie clatapie added the enhancement New features or code improvements label Oct 16, 2024
@clatapie clatapie self-assigned this Oct 16, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 16, 2024
@clatapie clatapie linked an issue Oct 16, 2024 that may be closed by this pull request
Add type hint new feature #309
Closed
@clatapie clatapie marked this pull request as ready for review October 16, 2024 15:49
@clatapie clatapie requested review from RobPasMue and germa89 October 16, 2024 15:49
RobPasMue
RobPasMue approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some complex code... I have the feeling it could be simplified but I think it's best we move forward honestly

@clatapie clatapie requested a review from RobPasMue October 17, 2024 14:39
RobPasMue
RobPasMue requested changes Oct 17, 2024
View reviewed changes
@clatapie clatapie merged commit 5be173a into main Oct 18, 2024
21 checks passed
@clatapie clatapie deleted the fix/docstring_length branch October 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@germa89 germa89 Awaiting requested review from germa89

Assignees

@clatapie clatapie

Labels

bug Something isn't working enhancement New features or code improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add type hint new feature

3 participants

@clatapie @RobPasMue