Skip to content

Conversation

@mkundu1
Copy link
Collaborator

@mkundu1 mkundu1 commented Aug 26, 2022

No description provided.

@mkundu1 mkundu1 requested a review from prmukherj August 26, 2022 12:59
@dnwillia-work
Copy link
Collaborator

dnwillia-work commented Aug 27, 2022

@RobPasMue and @mkundu1. I don't think the changes from #101 ever made it back into the main branch so the VTK dependency is not right on main. Probably that should be put back onto main before this.

@dnwillia-work dnwillia-work self-requested a review August 27, 2022 01:14
@mkundu1
Copy link
Collaborator Author

mkundu1 commented Aug 27, 2022

@RobPasMue and @mkundu1. I don't think the changes from #101 ever made it back into the main branch so the VTK dependency is not right on main. Probably that should be put back onto main before this.

@dnwillia-work Comparing main and release-0.4, VTK version looks to be fine in the main branch:

https://github.com/pyansys/pyfluent-visualization/blob/main/pyproject.toml#L29

https://github.com/pyansys/pyfluent-visualization/blob/release/0.4/pyproject.toml#L29

@dnwillia-work
Copy link
Collaborator

@RobPasMue and @mkundu1. I don't think the changes from #101 ever made it back into the main branch so the VTK dependency is not right on main. Probably that should be put back onto main before this.

@dnwillia-work Comparing main and release-0.4, VTK version looks to be fine in the main branch:

https://github.com/pyansys/pyfluent-visualization/blob/main/pyproject.toml#L29

https://github.com/pyansys/pyfluent-visualization/blob/release/0.4/pyproject.toml#L29

Yeah, ok, I see. I guess I got confused by the fact that the main branch seems to have a release number that is before the latest package we have released.

https://github.com/pyansys/pyfluent-visualization/blob/4eba449e5c6dcd8346af2ceef959eea95e480a88/pyproject.toml#L8

Is it supposed to be like that?

@prmukherj prmukherj self-requested a review August 28, 2022 08:01
@RobPasMue
Copy link
Member

Looks like the release branch and the main branch are both updated regarding the VTK change. I think it's just that the main branch has defined its version as 0.4.0. I recommend you to always "version" your main branch one minor version ahead of your release branch and with the "dev" version in patch. For example:

  • Latest release: 0.4.1
  • Version in main branch: 0.5.dev0

This is a typical version naming convention throughout the PyAnsys libraries

@mkundu1
Copy link
Collaborator Author

mkundu1 commented Aug 29, 2022

Consumed these changes in the intermittent dev release (#111)

@mkundu1 mkundu1 closed this Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants