Skip to content

Maint/drop python 3.9 #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 20, 2024
Merged

Maint/drop python 3.9 #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5fe273b
build: Bump version to v0.11.dev0
prmukherj Jun 21, 2024
7da40a0
Merge branch 'main' into release/v0.11.dev0
prmukherj Jun 24, 2024
cd34356
Merge branch 'release/v0.11.dev0' of https://github.com/pyansys/pyflu…
prmukherj Jul 2, 2024
d17fb8a
Merge branch 'main' of https://github.com/pyansys/pyfluent-visualizat…
prmukherj Jul 8, 2024
fe41ed1
Merge branch 'main' of https://github.com/pyansys/pyfluent-visualizat…
prmukherj Jul 9, 2024
de52b2e
Merge branch 'main' of https://github.com/pyansys/pyfluent-visualizat…
prmukherj Jul 16, 2024
9c7a215
Merge branch 'main' of https://github.com/pyansys/pyfluent-visualizat…
prmukherj Jul 24, 2024
616dea1
Merge branch 'main' of https://github.com/pyansys/pyfluent-visualizat…
prmukherj Aug 19, 2024
0cb64c3
refactor: Drop support for python 3.9
prmukherj Aug 19, 2024
b581bcc
Update pyfluent dependency to v0.25.dev1
prmukherj Aug 20, 2024
18069b3
Fix w.r.t. core repo
prmukherj Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ env:
# It applies 7 days retention policy by default.
RESET_EXAMPLES_CACHE: 0
ANSYSLMD_LICENSE_FILE: ${{ format('1055@{0}', secrets.LICENSE_SERVER) }}
MAIN_PYTHON_VERSION: '3.9'
MAIN_PYTHON_VERSION: '3.10'
PYFLUENT_TIMEOUT_FORCE_EXIT: 5
PYFLUENT_LAUNCH_CONTAINER: 1

Expand Down Expand Up @@ -51,7 +51,7 @@ jobs:
strategy:
matrix:
os: [windows-latest, ubuntu-latest]
python-version: ['3.9', '3.10', '3.11', '3.12']
python-version: ['3.10', '3.11', '3.12']
fail-fast: false

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-doc-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

env:
DOCUMENTATION_CNAME: 'visualization.fluent.docs.pyansys.com'
MAIN_PYTHON_VERSION: '3.9'
MAIN_PYTHON_VERSION: '3.10'
DOC_DEPLOYMENT_IMAGE_TAG: v24.2.0
ANSYSLMD_LICENSE_FILE: ${{ format('1055@{0}', secrets.LICENSE_SERVER) }}
PYFLUENT_TIMEOUT_FORCE_EXIT: 5
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-test-run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
strategy:
matrix:
os: [windows-latest, ubuntu-latest]
python-version: ['3.9', '3.10', '3.11', '3.12']
python-version: ['3.10', '3.11', '3.12']
fail-fast: false

steps:
Expand Down
4 changes: 2 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ the project support team, email `pyansys.core@ansys.com <pyansys.core@ansys.com>

Installation
------------
The ``ansys-fluent-visualization`` package supports Python 3.9 through Python
3.11 on Windows and Linux.
The ``ansys-fluent-visualization`` package supports Python 3.10 through Python
3.12 on Windows and Linux.

If you are using Python 3.10, download and install the wheel file for the ``vtk`` package from
`here for Windows <https://github.com/pyvista/pyvista-wheels/raw/main/vtk-9.1.0.dev0-cp310-cp310-win_amd64.whl>`_
Expand Down
4 changes: 2 additions & 2 deletions doc/source/getting_started/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ page on the Ansys website.
***************
Install package
***************
The ``ansys-fluent-visualization`` package supports Python 3.9 through
Python 3.11 on Windows and Linux.
The ``ansys-fluent-visualization`` package supports Python 3.10 through
Python 3.12 on Windows and Linux.

Install the latest release from `PyPi
<https://pypi.org/project/ansys-fluent-visualization/>`_ with:
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@ packages = [
]

[tool.poetry.dependencies]
python = ">=3.9,<4.0"
python = ">=3.10,<4.0"
importlib-metadata = {version = "^4.0", python = "<3.9"}
ansys-fluent-core = "~=0.23.dev0"
ansys-fluent-core = "~=0.25.dev1"
vtk = ">=9.3.0.rc0"
pyvista = ">=0.39.0"
pyvistaqt = ">=0.7.0"
Expand Down
8 changes: 4 additions & 4 deletions src/ansys/fluent/visualization/matplotlib/matplot_windows_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ def __call__(self):
"""Draw a monitor plot."""
if not self.post_object:
return
monitors_manager = self.post_object._api_helper.monitors_manager()
indices, columns_data = monitors_manager.get_monitor_set_data(
monitors = self.post_object._api_helper.monitors
indices, columns_data = monitors.get_monitor_set_data(
self.post_object.monitor_set_name()
)
xy_data = {}
Expand All @@ -183,8 +183,8 @@ def __call__(self):
properties = {
"curves": list(xy_data.keys()),
"title": monitor_set_name,
"xlabel": monitors_manager.get_monitor_set_prop(monitor_set_name, "xlabel"),
"ylabel": monitors_manager.get_monitor_set_prop(monitor_set_name, "ylabel"),
"xlabel": monitors.get_monitor_set_prop(monitor_set_name, "xlabel"),
"ylabel": monitors.get_monitor_set_prop(monitor_set_name, "ylabel"),
"yscale": "log" if monitor_set_name == "residual" else "linear",
}

Expand Down