Feat/plug in pyvista as plotter #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
ajain-work,
hpohekar,
mkundu1 and
seanpearsonuk
…pyansys/pyfluent-visualization into feat/plug_in_pyvista_as_plotter
Collaborator
|
Can you please add some description of the code change? |
mkundu1
reviewed
Oct 16, 2024
mkundu1
approved these changes
Oct 16, 2024
Collaborator
mkundu1
left a comment
mkundu1
left a comment
There was a problem hiding this comment.
Approving the refactoring change. We need to improve the animation workflow.
hpohekar
approved these changes
Oct 16, 2024
ajain-work
approved these changes
Oct 17, 2024
seanpearsonuk
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor PyVisualization to plug-in plotters as required by user.
Earlier, the graphics renderer code was dependent on "PyVista" and the plotter on "matplotlib" respectively. Now, they have been separated out of the infrastructure. For example, we have introduced a pyvista plotter as an alternative to matplotlib using an abstract class providing the basic infrastructure.
Most of the exposed user-interface remains unaffected by this though.