Skip to content

Conversation

@ajain-work
Copy link
Collaborator

No description provided.

@ajain-work ajain-work force-pushed the feat/vtk_dependency branch from 300ff33 to 8215c1a Compare August 8, 2022 02:23
@ajain-work ajain-work marked this pull request as ready for review August 8, 2022 02:24
@ajain-work ajain-work linked an issue Aug 8, 2022 that may be closed by this pull request
@ajain-work ajain-work requested a review from mkundu1 August 8, 2022 03:39
@ajain-work ajain-work force-pushed the feat/vtk_dependency branch from 1a3446e to abe091c Compare August 8, 2022 03:40
@RobPasMue RobPasMue self-requested a review August 8, 2022 05:25
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is an issue with documentation references if I am not mistaken:

/home/ansys/actions-runner/_work/pyfluent-visualization/pyfluent-visualization/doc/source/users_guide/postprocessing.rst:98: WARNING: duplicate label generate xy plot, other instance in /home/ansys/actions-runner/_work/pyfluent-visualization/pyfluent-visualization/doc/source/examples/00-postprocessing/post_processing_exhaust_manifold.rst

If that solves the doc generation issues, LGTM! Thanks for changing this @ajain-work

@RobPasMue RobPasMue self-requested a review August 8, 2022 05:57
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact it looks like your Nightly Build also failed prior to this change. So it should be solved in a different PR. LGTM!

@ajain-work ajain-work force-pushed the feat/vtk_dependency branch from 0c6c06f to 65e8f18 Compare August 8, 2022 16:06
@ajain-work ajain-work force-pushed the feat/vtk_dependency branch from 65e8f18 to 15858cd Compare August 8, 2022 16:27
@ajain-work ajain-work merged commit 67c32bf into main Aug 9, 2022
@ajain-work ajain-work deleted the feat/vtk_dependency branch August 9, 2022 10:41
RobPasMue pushed a commit that referenced this pull request Aug 10, 2022
* VTK Dependency.

* Doc build issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VTK dependency is very strict

4 participants