Skip to content

Fix for start_instance argument and some missing changes from 232 CI PR #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix for start_instance argument and some missing changes from 232 CI PR #1168

merged 1 commit into from
Dec 9, 2022

Conversation

mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Dec 7, 2022 •
edited
Loading

  1. Fix for start_instance argument which fixes the issue with server_info_filepath argument.
  2. Some changes I forgot to commit with the 23.2 CI PR.

@mkundu1 mkundu1 linked an issue Dec 7, 2022 that may be closed by this pull request
Should we allow using server_info_filepath also if not start_instance? #1142
Closed
mkundu1
mkundu1 commented Dec 7, 2022
View reviewed changes
@mkundu1 mkundu1 merged commit 5d1a78c into main Dec 9, 2022
@mkundu1 mkundu1 deleted the fix/start-instance branch December 9, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hpohekar hpohekar hpohekar approved these changes

@prmukherj prmukherj prmukherj approved these changes

@seanpearsonuk seanpearsonuk Awaiting requested review from seanpearsonuk seanpearsonuk is a code owner

@ajain-work ajain-work Awaiting requested review from ajain-work

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should we allow using server_info_filepath also if not start_instance?

3 participants

@mkundu1 @hpohekar @prmukherj