Consistent Fluent Version format. #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
ajain-work,
hpohekar,
mkundu1 and
seanpearsonuk
This was
linked to
issues
Dec 16, 2022
prmukherj
commented
Dec 19, 2022
mkundu1
approved these changes
Dec 19, 2022
hpohekar
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some inconsistencies how Fluent version is formatted at various places in the pyfluent code:
get_fluent_version() returns string "x.y.z"
launch_fluent accepts string "x.y"
launch_remote_fluent accepts string "xy"
set_ansys_version accepts string "x.y", float x.y, or an enum.
This has been addressed as part of this PR.
Please Note: This PR work is still in progress and it would be helpful to get your views on this. Thank you.
Current modification handles both cases even when the user enters "x.y.0" or "x.y".