Skip to content

Conversation

@mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Jan 3, 2023

This will fix the issue in running tests with some Fluent versions.

@mkundu1 mkundu1 requested a review from prmukherj January 3, 2023 14:39
@mkundu1 mkundu1 force-pushed the testing/version-markers branch from 056af93 to eef9927 Compare January 4, 2023 21:36
@prmukherj
Copy link
Collaborator

@mkundu1, if it is not very urgent can we merge this PR after the release? Actually, it might affect the existing tests and we might need to change some markers as well.
Thank you.

@prmukherj prmukherj closed this Jan 5, 2023
@prmukherj prmukherj reopened this Jan 5, 2023
@mkundu1
Copy link
Contributor Author

mkundu1 commented Jan 5, 2023

@mkundu1, if it is not very urgent can we merge this PR after the release? Actually, it might affect the existing tests and we might need to change some markers as well. Thank you.

Yes sure. Note that it won't require changing any existing markers unless some tests are wrongly marked, but there is no urgency to check that before the release.

@mkundu1 mkundu1 force-pushed the testing/version-markers branch from eef9927 to 5cd7fed Compare January 12, 2023 20:29
@codecov-commenter
Copy link

Codecov Report

Merging #1225 (5cd7fed) into main (c6e5522) will decrease coverage by 3.95%.
The diff coverage is n/a.

❗ Current head 5cd7fed differs from pull request most recent head 7bdcfb5. Consider uploading reports for the commit 7bdcfb5 to get more accurate results

@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
- Coverage   79.27%   75.31%   -3.96%     
==========================================
  Files          49       49              
  Lines        4641     4639       -2     
==========================================
- Hits         3679     3494     -185     
- Misses        962     1145     +183     

@mkundu1
Copy link
Contributor Author

mkundu1 commented Jan 12, 2023

@mkundu1 mkundu1 merged commit 9a55632 into main Jan 12, 2023
@mkundu1 mkundu1 deleted the testing/version-markers branch January 12, 2023 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants