Skip to content

Conversation

@mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Jan 4, 2023

Currently vale doesn't run at all:

  /github/home/vale --output=/lib/rdjsonl.tmpl --config=doc/.vale.ini doc
  E100 [vocab] Runtime error
  
  'rp' does not exist
  
  Execution stopped with code 1.

@dnwillia-work
Copy link
Collaborator

Ugh, how did this get broken? I see my basic change to fix up the readme earlier today has this error in the build pipeline:

https://github.com.mcas.ms/pyansys/pyfluent/actions/runs/3951427453/jobs/6765265555

yet that build step reported a success?

@dnwillia-work dnwillia-work requested a review from PipKat January 31, 2023 19:29
@dnwillia-work dnwillia-work linked an issue Jan 31, 2023 that may be closed by this pull request
@dnwillia-work dnwillia-work merged commit 1a47446 into main Feb 1, 2023
@dnwillia-work dnwillia-work deleted the doc/vale-fix branch February 1, 2023 11:12

.. code:: bash
.. vale off
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorgepiloto I had to deactivate vale for this code block because it was complaining about not knowing the words 'venv' and 'csh'. Do you have any idea why I would have needed to deactivate it for a code block? I would assume Vale is ignoring code blocks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue might be on the indentation of the code-snippet... it should be two spaces in. Hopefully that should solve the issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

   .. code:: bash

      python -m venv venv   # Set up a local virtual environment
      venv\Scripts\activate   # Activate the virtual environment on Windows
      source venv/bin/activate.csh   # Activate the virtual environment on Linux (csh)
      . venv/bin/activate   # Activate the virtual environment on Linux (bash)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it's weird in any case...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I got late to this ping. Glad to see everything got fixed.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys, let me try that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix vale errors

5 participants