-
Notifications
You must be signed in to change notification settings - Fork 56
Fix vale error in github #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vale error in github #1229
Conversation
|
Ugh, how did this get broken? I see my basic change to fix up the readme earlier today has this error in the build pipeline: https://github.com.mcas.ms/pyansys/pyfluent/actions/runs/3951427453/jobs/6765265555 yet that build step reported a success? |
573919b to
510aa2d
Compare
92a319c to
bf96522
Compare
9471041 to
5b3c896
Compare
|
|
||
| .. code:: bash | ||
| .. vale off |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorgepiloto I had to deactivate vale for this code block because it was complaining about not knowing the words 'venv' and 'csh'. Do you have any idea why I would have needed to deactivate it for a code block? I would assume Vale is ignoring code blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the issue might be on the indentation of the code-snippet... it should be two spaces in. Hopefully that should solve the issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.. code:: bash
python -m venv venv # Set up a local virtual environment
venv\Scripts\activate # Activate the virtual environment on Windows
source venv/bin/activate.csh # Activate the virtual environment on Linux (csh)
. venv/bin/activate # Activate the virtual environment on Linux (bash)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it's weird in any case...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I got late to this ping. Glad to see everything got fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks guys, let me try that.
Currently vale doesn't run at all: