Check for file modification in test #1308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
ajain-work,
alikasim72,
hpohekar and
seanpearsonuk
seanpearsonuk
approved these changes
Jan 26, 2023
|
@mkundu1 good thinking, thanks |
hpohekar
approved these changes
Jan 27, 2023
prmukherj
approved these changes
Jan 30, 2023
prmukherj
reviewed
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
test_start_transcript_file_writeis randomly failing probably due to server to holding the file while the client tries to read it. Change to check for file modification instead of file content.