Fix is_active checks #1320
Merged
Fix is_active checks #1320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
commented
Feb 1, 2023
mkundu1
commented
Feb 1, 2023
mkundu1
force-pushed
the
fix/is-active
branch
from
52e36c2 to
29069b1
Compare
mkundu1
force-pushed
the
fix/is-active
branch
from
29069b1 to
ae918f2
Compare
prmukherj
approved these changes
Feb 6, 2023
seanpearsonuk
approved these changes
Feb 6, 2023
mkundu1
commented
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fluent bugs 774607, 774755, 774903
For all these defects,
is_active()returns a list from Fluent for which we need to cast to boolean type in PyFluent. There are many such occurrences in Fluent code, it is probably not possible to find and change the Fluent code everywhere.