Skip to content

Suggest closest matching names for config-vars error. #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2023
Merged

Suggest closest matching names for config-vars error. #1372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45e242e
Suggest closest matching names for config-vars error.
Feb 19, 2023
8006edb
Raise value error instead of Runtime Error.
Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ansys/fluent/core/filereader/case.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import h5py

from . import lispy
from ..allowed_name_error_msg import allowed_name_error_message


class InputParameter:
Expand Down Expand Up @@ -99,7 +100,11 @@ def __call__(self, name: str = ""):
if not name:
error_name = self._path[:-1] if self._path else self._path
raise RuntimeError(f"Invalid variable {error_name}")
return self._variables[name]
try:
return self._variables[name]
except KeyError:
raise ValueError(allowed_name_error_message(
"config-vars", name, list(self._variables.keys())))

def __getattr__(self, name: str):
for orig, sub in (
Expand Down
6 changes: 6 additions & 0 deletions tests/test_casereader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,12 @@ def test_case_reader_get_rp_and_config_vars():
with pytest.raises(BaseException):
reader.rp_var.defaults.pre_r19__dot0_early()

with pytest.raises(ValueError) as msg:
reader.config_var("rp-3d")

assert msg.value.args[0] == "rp-3d is not an allowed config-vars name.\n" \
"The most similar names are: rp-3d?, rp-des?."


def test_case_reader_input_parameter():
number = InputParameter(raw_data=(("name", "n"), ("definition", "12.4")))
Expand Down