Skip to content

Use random port in unittests #1384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use random port in unittests #1384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/ansys/fluent/core/launcher/fluent_container.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
import os
from pathlib import Path
import socket
import subprocess
import tempfile
import time
from typing import List

from ansys.fluent.core.session import parse_server_info_file


def _get_free_port() -> int:
sock = socket.socket()
sock.bind(("", 0))
return sock.getsockname()[1]
from ansys.fluent.core.utils.network import get_free_port


def start_fluent_container(mounted_from: str, mounted_to: str, args: List[str]) -> int:
Expand All @@ -38,7 +32,7 @@ def start_fluent_container(mounted_from: str, mounted_to: str, args: List[str])
os.close(fd)
timeout = 100
license_server = os.environ["ANSYSLMD_LICENSE_FILE"]
port = _get_free_port()
port = get_free_port()
password = ""
container_sifile = mounted_to + "/" + Path(sifile).name
image_tag = os.getenv("FLUENT_IMAGE_TAG", "v23.1.0")
Expand Down
15 changes: 15 additions & 0 deletions src/ansys/fluent/core/utils/network.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import socket


def get_free_port() -> int:
"""Identifies a free port to which a new socket connection can be
established.

Returns
-------
int
port number
"""
sock = socket.socket()
sock.bind(("", 0))
return sock.getsockname()[1]
15 changes: 8 additions & 7 deletions tests/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from ansys.fluent.core.examples import download_file
from ansys.fluent.core.fluent_connection import _FluentConnection
from ansys.fluent.core.session import _BaseSession
from ansys.fluent.core.utils.network import get_free_port


class MockHealthServicer(health_pb2_grpc.HealthServicer):
Expand Down Expand Up @@ -74,7 +75,7 @@ def SchemeEval(
def test_create_session_by_passing_ip_and_port_and_password() -> None:
server = grpc.server(futures.ThreadPoolExecutor(max_workers=1))
ip = "127.0.0.1"
port = 50051
port = get_free_port()
server.add_insecure_port(f"{ip}:{port}")
health_pb2_grpc.add_HealthServicer_to_server(MockHealthServicer(), server)
scheme_eval_pb2_grpc.add_SchemeEvalServicer_to_server(
Expand All @@ -95,7 +96,7 @@ def test_create_session_by_setting_ip_and_port_env_var(
) -> None:
server = grpc.server(futures.ThreadPoolExecutor(max_workers=1))
ip = "127.0.0.1"
port = 50051
port = get_free_port()
server.add_insecure_port(f"{ip}:{port}")
health_pb2_grpc.add_HealthServicer_to_server(MockHealthServicer(), server)
scheme_eval_pb2_grpc.add_SchemeEvalServicer_to_server(
Expand All @@ -114,7 +115,7 @@ def test_create_session_by_setting_ip_and_port_env_var(
def test_create_session_by_passing_grpc_channel() -> None:
server = grpc.server(futures.ThreadPoolExecutor(max_workers=1))
ip = "127.0.0.1"
port = 50051
port = get_free_port()
server.add_insecure_port(f"{ip}:{port}")
health_pb2_grpc.add_HealthServicer_to_server(MockHealthServicer(), server)
scheme_eval_pb2_grpc.add_SchemeEvalServicer_to_server(
Expand All @@ -134,7 +135,7 @@ def test_create_session_by_passing_grpc_channel() -> None:
def test_create_session_from_server_info_file(tmp_path: Path) -> None:
server = grpc.server(futures.ThreadPoolExecutor(max_workers=1))
ip = "127.0.0.1"
port = 50051
port = get_free_port()
server.add_insecure_port(f"{ip}:{port}")
health_pb2_grpc.add_HealthServicer_to_server(MockHealthServicer(), server)
scheme_eval_pb2_grpc.add_SchemeEvalServicer_to_server(
Expand All @@ -157,7 +158,7 @@ def test_create_session_from_server_info_file_with_wrong_password(
) -> None:
server = grpc.server(futures.ThreadPoolExecutor(max_workers=1))
ip = "127.0.0.1"
port = 50051
port = get_free_port()
server.add_insecure_port(f"{ip}:{port}")
scheme_eval_pb2_grpc.add_SchemeEvalServicer_to_server(
MockSchemeEvalServicer(), server
Expand All @@ -177,7 +178,7 @@ def test_create_session_from_server_info_file_with_wrong_password(
def test_create_session_from_launch_fluent_by_passing_ip_and_port_and_password() -> None:
server = grpc.server(futures.ThreadPoolExecutor(max_workers=1))
ip = "127.0.0.1"
port = 50051
port = get_free_port()
server.add_insecure_port(f"{ip}:{port}")
health_pb2_grpc.add_HealthServicer_to_server(MockHealthServicer(), server)
scheme_eval_pb2_grpc.add_SchemeEvalServicer_to_server(
Expand Down Expand Up @@ -207,7 +208,7 @@ def test_create_session_from_launch_fluent_by_setting_ip_and_port_env_var(
) -> None:
server = grpc.server(futures.ThreadPoolExecutor(max_workers=1))
ip = "127.0.0.1"
port = 50051
port = get_free_port()
server.add_insecure_port(f"{ip}:{port}")
health_pb2_grpc.add_HealthServicer_to_server(MockHealthServicer(), server)
scheme_eval_pb2_grpc.add_SchemeEvalServicer_to_server(
Expand Down