Skip to content

Conversation

@mkundu1
Copy link
Contributor

@mkundu1 mkundu1 commented Feb 22, 2023

This PR intends to resolve connection issues within VPN network by automatically inferring the remoting ip address and setting it to REMOTING_SERVER_ADDRESS env. var. before launching Fluent. It loops through the ip addresses returned by getaddinfo and picks up the one with which a grpc connection can be established.

The mechanism can be disabled by setting pyfluent.INFER_REMOTING_IP = False.

Copy link
Collaborator

@seanpearsonuk seanpearsonuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, thanks

@mkundu1 mkundu1 merged commit a566cf8 into main Feb 23, 2023
@mkundu1 mkundu1 deleted the feat/remoting-ip branch February 23, 2023 12:40
mkundu1 added a commit that referenced this pull request Mar 16, 2023
* Determine remoting ip address

* Infer remoting ip address

* Infer remoting ip address

* Infer remoting ip address
mkundu1 added a commit that referenced this pull request Mar 17, 2023
* Infer remoting ip address (#1386)

* Determine remoting ip address

* Infer remoting ip address

* Infer remoting ip address

* Infer remoting ip address

* Bump version 0.12.5

* Code cleanup

* pre-commit fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document REMOTING_SERVER_ADDRESS env var usage to fix VPN related issues

5 participants