Testing/increasing coverage #1416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sys/pyfluent into testing/increasing_coverage
Adam-Boutin
requested review from
ajain-work,
alikasim72,
dnwillia-work,
h-krishnan,
hpohekar,
mkundu1,
prmukherj and
seanpearsonuk
as code owners
for more information, see https://pre-commit.ci
|
Looks good to me too. Please can you either a) pre-squash all your commits or b) squash and merge them. |
dnwillia-work
approved these changes
Mar 6, 2023
seanpearsonuk
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added 4 extra tests to tests/test_scheduler.py. These tests are as follows:
test_machine_info:
This makes sure that calling load_machines() with machine_info gets correctly sorted through the elif block.
test_restrict_machines:
This test checks that if test_restrict_machines() is called directly it will not alter a machine list that has less than or equal to the ncores specified.
test_lsb_mcpu:
simply makes sure that "LSB_MCPU_HOSTS" is checked for a possible host list.
test_no_machine_name:
Checks to make sure that _parse_host_info will throw the 'Problem with machine list format.' exception if there is a blank machine name.
Please let me know if there is anything incorrect, poor logic, or unneeded tests here.
If this is accepted this will be my first contribution. I would be happy to receive any feedback and look forward to working on more testing.