Feat/cache #1418
Merged
Feat/cache #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
reviewed
Mar 7, 2023
seanpearsonuk
commented
Mar 7, 2023
seanpearsonuk
commented
Mar 7, 2023
src/ansys/fluent/core/streaming_services/datamodel_streaming.py
Outdated
Show resolved
Hide resolved
mkundu1
reviewed
Mar 7, 2023
mkundu1
reviewed
Mar 7, 2023
|
@mkundu1 this is looking very good - many thanks for taking it on! Do we still think there's an issue with BeginStreaming on the server-side for some datamodels (e.g., workflow)? |
@seanpearsonuk I don't think there are any issues with BeginStreaming on the server-side for specific datamodel. We will probably face some issues due to usage of NoCommandsDifferencer for extracting the diff in server side. |
|
Rebased and squashed the branch |
seanpearsonuk
requested review from
ajain-work,
alikasim72,
dnwillia-work,
h-krishnan,
hpohekar and
prmukherj
as code owners
hpohekar
approved these changes
Mar 28, 2023
mkundu1
force-pushed
the
feat/cache
branch
2 times, most recently
from
54e3e9e to
95d7bb6
Compare
mkundu1
reviewed
Mar 30, 2023
prmukherj
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data model caching. I created the PR and did a tiny amount of work at the start, so I cannot approve. Thanks @mkundu1; I think this is ready to go in now?