Added test for accessor methods in flobject.py #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
ajain-work,
alikasim72,
dnwillia-work,
h-krishnan,
hpohekar and
mkundu1
as code owners
|
@seanpearsonuk, this PR is ready. This test is taking approximately 85 seconds to run. Shall we merge this to the main branch or keep the test only as part of nightly CI? |
mkundu1
reviewed
Apr 19, 2023
mkundu1
approved these changes
Apr 21, 2023
hpohekar
approved these changes
Apr 21, 2023
mkundu1
reviewed
Apr 21, 2023
mkundu1
reviewed
Apr 21, 2023
added 2 commits
April 21, 2023 15:29
seanpearsonuk
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests the availability / behavior of accessor methods like: is_active, is_read_only, min, max, default_value and allowed_values, on settings objects of all types.