Skip to content

Conversation

@prmukherj
Copy link
Collaborator

@prmukherj prmukherj commented Mar 29, 2023

We were getting a null string from server in transcript which was not handled.

@seanpearsonuk
Copy link
Collaborator

@prmukherj I have removed the internal link

@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Mar 29, 2023

Great work @prmukherj, thanks!

@prmukherj
Copy link
Collaborator Author

Thank you @seanpearsonuk. Sorry, forgot about that internal link issue.

@seanpearsonuk
Copy link
Collaborator

I have added #1505 in relation to this.

@dnwillia-work dnwillia-work linked an issue Mar 29, 2023 that may be closed by this pull request
@dnwillia-work
Copy link
Collaborator

@prmukherj I have removed the internal link

and I removed the mention of the internal ID as well. It's probably best to put an issue for this sort of thing into the PyFluent repo since it required changes to the library.

I have added #1505 in relation to this.

I added a link to it under the Development heading on the right.

@seanpearsonuk seanpearsonuk linked an issue Mar 29, 2023 that may be closed by this pull request
@seanpearsonuk
Copy link
Collaborator

@prmukherj I have removed the internal link

and I removed the mention of the internal ID as well. It's probably best to put an issue for this sort of thing into the PyFluent repo since it required changes to the library.

I have added #1505 in relation to this.

I added a link to it under the Development heading on the right.

The linked issue #1506 mentions the Fluent bug by ID (just as I did here). We do this for all bugs in https://github.com/orgs/pyansys/projects/23, which makes defect management easier, without revealing significant information. On the Fluent side, we hyperlink to here, but not the reverse.

@prmukherj prmukherj merged commit 4cbf811 into main Mar 29, 2023
@prmukherj prmukherj deleted the fix/bug_in_transcript_streaming branch March 29, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transcript streaming halted by IndexError

5 participants