Skip to content

Conversation

@prmukherj
Copy link
Collaborator

transcript.start()  # write to stdout only

transcript.start(file_path="a.trn")  # write to file only

transcript.start(file_path="a.trn", write_to_stdout=True)  # write to both file and stdout

Copy link
Contributor

@mkundu1 mkundu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Please check if all 3 cases are covered in unittests before merging.

@prmukherj prmukherj merged commit 325bb1d into main Mar 31, 2023
@prmukherj prmukherj deleted the fix/transcript_behaviour branch March 31, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

transcript.start behaviour

4 participants