Skip to content

Rename number -> numeric_value #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Rename number -> numeric_value #1516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/ansys/fluent/core/filereader/case_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ def units(self) -> str:
return self._component(1).lstrip("[").rstrip("]")

@property
def number(self):
"""Get the value of a Fluent input parameter.
def numeric_value(self):
"""Get the numeric value of a Fluent input parameter.
Returns
-------
float
Value of the Fluent input parameter.
Numeric value of the Fluent input parameter.
"""
return float(self._component(0))

Expand Down
8 changes: 4 additions & 4 deletions tests/test_casereader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ def call_casereader(
assert reader.num_dimensions() == expected["num_dimensions"]
assert reader.iter_count() == expected["iter_count"]
assert {
p.name: (p.number, p.units) for p in reader.input_parameters()
p.name: (p.numeric_value, p.units) for p in reader.input_parameters()
} == expected["input_parameters"]
assert {p.name: p.units for p in reader.output_parameters()} == expected[
"output_parameters"
Expand Down Expand Up @@ -204,14 +204,14 @@ def test_case_reader_input_parameter():

assert number.name == "n"
assert number.units == ""
assert number.number == 12.4
assert number.numeric_value == 12.4
assert number.value == "12.4"

length = InputParameter(raw_data=(("name", "x"), ("definition", "12.4 [m]")))

assert length.name == "x"
assert length.units == "m"
assert length.number == 12.4
assert length.numeric_value == 12.4
assert length.value == "12.4 [m]"

momentum = InputParameter(
Expand All @@ -220,5 +220,5 @@ def test_case_reader_input_parameter():

assert momentum.name == "p"
assert momentum.units == "kg m s^-1"
assert momentum.number == 12.4
assert momentum.numeric_value == 12.4
assert momentum.value == "12.4 [kg m s^-1]"