Case Reader to parse numerical values with units. #1570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prmukherj
requested review from
ajain-work,
alikasim72,
dnwillia-work,
h-krishnan,
hpohekar,
mkundu1 and
seanpearsonuk
as code owners
2 tasks
seanpearsonuk
approved these changes
May 2, 2023
ajain-work
approved these changes
May 3, 2023
tejalprabhu01
approved these changes
May 3, 2023
2 tasks
mkundu1
approved these changes
May 3, 2023
added 2 commits
May 3, 2023 20:15
…ub.com/pyansys/pyfluent into fix/case_reader_parse_values_with_unit Merged into local.
mkundu1
pushed a commit
that referenced
this pull request
May 3, 2023
* Case Reader to parse numerical values with units. * Updated logic. * Update value. * endswith instead of suffixes. * Update endswith -> Path-match * Improve error handling. * Update test with correct error type. --------- Co-authored-by: Your Name <you@example.com>
mkundu1
added a commit
that referenced
this pull request
May 4, 2023
* Case Reader to parse numerical values with units. (#1570) * Case Reader to parse numerical values with units. * Updated logic. * Update value. * endswith instead of suffixes. * Update endswith -> Path-match * Improve error handling. * Update test with correct error type. --------- Co-authored-by: Your Name <you@example.com> * Bump version 0.13.1 --------- Co-authored-by: Prithwish Mukherjee <109645853+prmukherj@users.noreply.github.com> Co-authored-by: Your Name <you@example.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Case Reader was not able to parse numerical values like: 2[m/s].
That behavior has been fixed.