Slight rewording change for version check #1606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raph-luc
requested review from
h-krishnan,
hpohekar,
mkundu1,
prmukherj and
seanpearsonuk
as code owners
prmukherj
approved these changes
May 17, 2023
seanpearsonuk
approved these changes
May 17, 2023
hpohekar
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change. While testing different Fluent releases, I got this error message:
However, Fluent version 24.1 does exist in my machine, so I got confused for a second there. I believe what the original dev meant is that it is not yet supported by pyfluent.
With the proposed changes, the message now reads:
Additional thought probably for a different PR: do we need to block the execution of more recent versions than the latest fully supported Fluent release? Shouldn't more recent versions (always? usually?) work fine from now on? Perhaps just a warning that the recent/dev version is untested and subject to potential issues?